Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • A assignment-image-rotation
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • programming-languages
  • assignment-image-rotation
  • Merge requests
  • !77

Closed
Created Dec 31, 2021 by Ivan Nesterov@nesterrovv
  • Report abuse
Report abuse

Nesterov Ivan, R3237, Image rotation lab

  • Overview 6
  • Commits 52
  • Pipelines 50
  • Changes 9

Last changes before review: I found the errors pointed out by the sanitizers asan and lsan, fixed memory leaks and problems with it, corrected inaccuracies in the code style and decomposed files into directories correctly, according to the statement of work. Hopefully this code is now not as ugly as last pre-new year's version :) . P.S. I hope you will read PLEASE_READ_IT.pdf file before this code review

UPD: changes after review

  1. free_image function moved from main.c to bmp_manipulator.c
  2. ../include/ prefix removed from #include strings as unnecessary
  3. Changed the logic of image rotation. Previously, it did not occur to me how to rotate the picture counterclockwise, so I rotated it three times clockwise. At the moment, the function has been changed and rotates the image correctly
Edited Jan 20, 2022 by Ivan Nesterov
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: master