Nikita krutoy

src/bmp.c

     };
 }
 
+enum read_status validate_header(FILE* in, struct bmp_header* header) {
+    if (!read_header(in, header)) return READ_INVALID_HEADER;
+    if (header->bfType != BMP_TYPE) return READ_INVALID_SIGNATURE;
+    if ((header->bOffBits - ftell(in) > 0)) {
+        if (fseek(in, header->bOffBits - ftell(in), 1)) return READ_INVALID_HEADER;
+    }
+    return READ_OK;
+}
 
 
 enum read_status from_bmp(FILE* in, struct image* image) {
     struct bmp_header header = {};
-    if (!read_header(in, &header)) return READ_INVALID_HEADER;
-    if (header.bfType != BMP_TYPE) return READ_INVALID_SIGNATURE;
-    if ((header.bOffBits - ftell(in) > 0)) {
-        if (fseek(in, header.bOffBits - ftell(in), 1)) return READ_INVALID_HEADER;
+
+    const enum read_status header_read_status = validate_header(in, &header);
+
+    if (header_read_status != READ_OK) {
+        return header_read_status;
     }
 
     const size_t padding = calc_padding(header.biWidth);

src/file_io.c

 enum read_status read_image(const char* filename, struct image* image, to_image_data to_image) {
     FILE* file = fopen(filename, "r");
     if (!file) return READ_SOURCE_ACCESS_FAILED;
-    enum read_status status = to_image(file, image);
+    const enum read_status status = to_image(file, image);
     fclose(file);
     return status;
 }
 enum write_status write_image(const char* filename, struct image* image, to_file write_to_file) {
     FILE* file = fopen(filename, "w");
     if (!file) return WRITE_SOURCE_ACCESS_FAILED;
-    enum write_status status = write_to_file(file, image);
+    const enum write_status status = write_to_file(file, image);
     fclose(file);
     return status;
 }

src/main.c

 #include "util.h"
 #include "bmp.h"
 
-static char* const write_error_messages[] = {
+static const char* const write_error_messages[] = {
         [WRITE_OK] = "Done",
         [WRITE_ERROR] = "Failed to write data to file",
         [WRITE_SOURCE_ACCESS_FAILED] = "Could not access the file"
 };
 
-static char* const read_error_messages[] = {
+static const char* const read_error_messages[] = {
         [READ_OK] = "Done",
         [READ_INVALID_BITS] = "Failed to read pixels: invalid bits",
         [READ_INVALID_HEADER] = "Invalid file header",

src/rotate.c

     struct pixel* pixels = malloc(sizeof(struct pixel) * source.width * source.height);
     for (uint64_t y = 0; y < source.height; y++) {
         for (uint64_t x = 0; x < source.width; x++) {
-            size_t index = get_pixel_index_from_coords(x, y, source.width);
-            uint64_t newX = rotate_x_90(y, source.height);
-            uint64_t newY = rotate_y_90(x);
-            size_t new_index = get_pixel_index_from_coords(newX, newY, source.height);
+            const size_t index = get_pixel_index_from_coords(x, y, source.width);
+            const uint64_t newX = rotate_x_90(y, source.height);
+            const uint64_t newY = rotate_y_90(x);
+            const size_t new_index = get_pixel_index_from_coords(newX, newY, source.height);
             pixels[new_index] = source.data[index];
         }
     }