first-clab

Laboratory work

solution/include/bmp.h

 #include <inttypes.h>
 
 
-struct __attribute__((packed)) bmp_header{
-        uint16_t bfType;
-        uint32_t  bfileSize;
-        uint32_t bfReserved;
-        uint32_t bOffBits;
-        uint32_t biSize;
-        uint32_t biWidth;
-        uint32_t  biHeight;
-        uint16_t  biPlanes;
-        uint16_t biBitCount;
-        uint32_t biCompression;
-        uint32_t biSizeImage;
-        uint32_t biXPelsPerMeter;
-        uint32_t biYPelsPerMeter;
-        uint32_t biClrUsed;
-        uint32_t  biClrImportant;
-
-};
-
 enum image_rotation_status_code bmp_file_read(const char* filepath, struct image* image);
 
 enum image_rotation_status_code bmp_file_write(const char* filepath, struct image* image);

solution/src/bmp.c

 
 
 
+struct __attribute__((packed)) bmp_header{
+    uint16_t bfType;
+    uint32_t  bfileSize;
+    uint32_t bfReserved;
+    uint32_t bOffBits;
+    uint32_t biSize;
+    uint32_t biWidth;
+    uint32_t  biHeight;
+    uint16_t  biPlanes;
+    uint16_t biBitCount;
+    uint32_t biCompression;
+    uint32_t biSizeImage;
+    uint32_t biXPelsPerMeter;
+    uint32_t biYPelsPerMeter;
+    uint32_t biClrUsed;
+    uint32_t  biClrImportant;
+
+};
 
 static bool valid_signature(struct bmp_header const *header){
     return (header->bfType == HEADER_SIGNATURE);
     const uint8_t padding = calculate_padding(image->width);
 
 
-    if (!fseek(file, offset, SEEK_SET))
+    if (fseek(file, offset, SEEK_SET))
         {
-            image_free(image);
             return false;
         }
 
         items_read = fread(image->data + i * image->width, PIXEL_SIZE, image->width, file );
 
 
-        if(items_read != image->width || !fseek(file, padding, SEEK_CUR)){
-            image_free(image);
+        if(items_read != image->width || fseek(file, padding, SEEK_CUR)){
             return false;
         }
     }
     reads bmp_file from file
 */
 static enum image_rotation_status_code bmp_image_read(FILE* in, struct image *image){
-    if (!fseek(in, 0, SEEK_SET)) return FILE_SEEK_ERROR;
+    if (fseek(in, 0, SEEK_SET)) return FILE_SEEK_ERROR;
     struct bmp_header header = {0};
 
-
     if (!bmp_read_header(in, &header)){
         return BMP_HEADER_READ_ERROR;
     }
     }
 
     if (!bmp_read_bitmap(in, image, header.bOffBits)){
+        image_free(image);
         return BMP_BITMAP_READ_ERROR;
     }
 
     const uint8_t padding = calculate_padding(image->width);
 
     uint8_t garbage[3] = {0, 0, 0};
-
-    if (!fseek(file, offset, SEEK_SET)) return FILE_SEEK_ERROR;
+    if (fseek(file, offset, SEEK_SET)) return FILE_SEEK_ERROR;
     for (size_t i = 0; i < image->height; i++){
         uint32_t items_written = fwrite(image->data + (image->width * i), PIXEL_SIZE, image->width, file);
 
 
     enum image_rotation_status_code code;
 
-    if (!fseek(out, 0, SEEK_SET)) return FILE_SEEK_ERROR;
+    if (fseek(out, 0, SEEK_SET)) return FILE_SEEK_ERROR;
     struct bmp_header header = bmp_header_from_image(image);
-
     code = bmp_write_header(out, &header);
-    if (!code) {
+    if (code) {
         return code;
     }
 
     code = bmp_write_bitmap(out, image, header.bOffBits);
 
-    if (!code){
+    if (code){
         return code;
     }